Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: strf-8846 Send stencil-cli header to storefront api #789

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix: strf-8846 Send stencil-cli header to storefront api #789

merged 1 commit into from
Oct 13, 2021

Conversation

jairo-bc
Copy link
Contributor

What?

Sending stencil-cli header to storefront api

Tickets / Documentation

cc @bigcommerce/storefront-team

@jairo-bc jairo-bc requested review from zvuki and jmwiese October 13, 2021 15:31
bookernath
bookernath approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@bookernath bookernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, need to fix test failures

@jairo-bc
Copy link
Contributor Author

Code looks good, need to fix test failures

That was linting. Done

@jairo-bc jairo-bc merged commit aefa595 into bigcommerce:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bookernath bookernath bookernath approved these changes

@zvuki zvuki zvuki approved these changes

@jmwiese jmwiese Awaiting requested review from jmwiese

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jairo-bc @zvuki @bookernath