fix(storefront): BCTHEME-1000 handle correctly css extension in stencil #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on Prelude POC we would like to change new Stencil Theme structure:
dist/css
dir,css
extension for it.css_compiler
flagIf we use mentioned structure,
stencil-cli
gives us an error in local development. For this reason we would like to add possibility forstencil-cli
to work with regular css as well asaseets/scss
directory. On theme side, we will usecss_compiler
flag fromconfig.json
that can be switched betweenscss
andcss
. On Stencil side we will provide this extension toCSS Compiler Handler
which then will assemble CSS accordingly.Tickets / Documentation
Screenshots (if appropriate)
cornerstone_test_after_720p.mov
new_theme_test_after_720p.mov
Here our Theme structure at the moment
cc @bigcommerce/storefront-team