fix: when there's no regions on the page #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwiese
reviewed
Feb 23, 2022
lib/content-api-client.js
Outdated
| @@ -31,6 +31,9 @@ async function getRenderedRegionsByPageType({ accessToken, storeUrl, pageType }) | |||
| }), | |||
| }); | |||
|
|
|||
| if (!response.data.data) { | |||
| return { renderedRegions: []}; | |||
There was a problem hiding this comment.
This would probably fix the problem from a stencil-cli perspective, but do we know if there a more root cause as to why this regions object isnt populating? Is it just not being passed in properly?
There was a problem hiding this comment.
I had the same exact comment in the slack. I feel the issue is present somewhere else. getRenderedRegionByPageType has nothing to do with the theme. I have a feeling we are not passing down all the required params for the endpoint which could be the reason it's breaking.
There was a problem hiding this comment.
As long as we've captured the follow up work I think we can continue with this as a fix in the short term
jairo-bc
force-pushed
the
fix-issue-with-regions
branch
from
f12499d to
a94f205
Compare
jmwiese
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Sometimes, when new theme is applied to the store, I don't receive
regionsobject from the API.Screenshots (if appropriate)
cc @bigcommerce/storefront-team, @jkanive