feat(storefront): bctheme-1063 modify stencil to start locally with components ui library #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BC-krasnoshapka
approved these changes
Mar 23, 2022
jairo-bc
requested changes
Mar 23, 2022
lib/template-assembler.js
Outdated
| * @param templateName | ||
| */ | ||
| function getCustomPath(templatesFolder, templateName) { | ||
| const packageFlag = 'external/'; |
There was a problem hiding this comment.
I believe it's not a flag. A flag is usually considerer a boolean variable.
There was a problem hiding this comment.
it's changed to packageMarker since it indicates which source has been used for template.
@jairo-bc how do you find this name?
lib/template-assembler.js
Outdated
| * Takes a templates folder and template name. It returns simple path for custom template if it's available | ||
| * or use default folder instead | ||
| * | ||
| * @param templatesFolder |
There was a problem hiding this comment.
Do you mind adding a type here and below?
|
@bc-alexsaiannyi @BC-krasnoshapka I believe it's just a |
bc-alexsaiannyi
force-pushed
the
bctheme-1063
branch
from
f4160b0 to
12ce05c
Compare
jairo-bc
approved these changes
Mar 24, 2022
|
is it @bc-alexsaiannyi fully tested and ready to be merged? |
|
Let's wait with merging. I believe we should continue with stencil bundle and storefront-renderer parts, and then merge everything when whole idea proves its viability. |
yurytut1993
approved these changes
Mar 29, 2022
…omponents ui library
bc-alexsaiannyi
force-pushed
the
bctheme-1063
branch
from
12ce05c to
eccacb9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
With this PR we would like to add opportunity to use templates or styles via external BigCommerce Lib( it will be created later). For this purpose we are going to implement a rule that indicates it's been taken from the external package and not from a directory within a Theme.
For instance:
{{> external/bc-ui-lib/templates/carousel-content }}external/ is a flag that template comes from some external lib.while
{{> components/common/carousel-content}}. is a default way to use html component within a Theme.Tickets / Documentation
Screenshots (if appropriate)
TBD
cc @bigcommerce/storefront-team