feat: STRF-9741 Verbose error logging in Stencil CLI #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-bc
force-pushed
the
STRF-9741
branch
2 times, most recently
from
38ff53b to
908ebe2
Compare
bc-max
reviewed
Apr 20, 2022
bc-max
approved these changes
Apr 20, 2022
zvuki
reviewed
Apr 20, 2022
lib/cliCommon.js
Outdated
| console.log(`URL: `.yellow + config.url); | ||
| console.log(`Method: `.yellow + config.method.toUpperCase()); | ||
| console.log(`Headers:`.yellow); | ||
| printObject(config.headers); |
There was a problem hiding this comment.
let's not print headers, as they may contain auth tokens
zvuki
reviewed
Apr 20, 2022
CHANGELOG.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| ### Draft | |||
|
|
|||
| - feat: STRF-9741 Verbose error logging in Stencil CLI by default ([x](https://github.com/bigcommerce/stencil-cli/pull/x)) | |||
There was a problem hiding this comment.
can you add a line on how to disable it?
|
@jairo-bc Do you have an example of the output when an error happens? |
|
|
jairo-bc
force-pushed
the
STRF-9741
branch
2 times, most recently
from
53272f6 to
0794605
Compare
zvuki
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Introduced verbose network requests logging.
Tickets / Documentation
Screenshots (if appropriate)
cc @bigcommerce/storefront-team