feat: STRF-9807 Dockerize stencil cli #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-max
approved these changes
May 25, 2022
README.md
Outdated
| For example | ||
| `docker run -p 3005:3005 -v /bigcommerce/cornerstone:/usr/src/app -it bc/stencil-cli stencil init`, where `3005` is port number definded in `config.stencil.json` and `/bigcommerce/cornerstone` path to where theme is located. | ||
|
|
||
| `docker run -p 3005:3005 -v /bigcommerce/cornerstone:/usr/src/app -it bc/stencil-cli stencil start` and so on |
There was a problem hiding this comment.
this line seem to be redundant as it is exactly the same what we have on 108
There was a problem hiding this comment.
not exactly, it has another command at the end
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Dockerize stencil cli
Steps to run it locally
docker build . -t bc/stencil-cli(bc/stencil-cli - name of image, it's possible to set any)docker run -p 3005:3005 -v /bigcommerce/cornerstone:/usr/src/app -it bc/stencil-cli stencil start3005- port fromconfig.stencil.json/bigcommerce/cornerstone- path to the theme directoryTickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
cc @bigcommerce/storefront-team