Add getSrcset method #106
Merged
Add getSrcset method #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team |
bookernath
force-pushed
the
getSrcset
branch
11 times, most recently
from
55db99d
to
99bdcf9
Compare
|
Everything looks good to me. Just a small optimization but https://benediktmeurer.de/2017/04/03/v8-behind-the-scenes-march-edition/ says that writing JavaScript declaratively can make programs run faster. |
bookernath
force-pushed
the
getSrcset
branch
2 times, most recently
from
40956c0
to
5203a66
Compare
junedkazi
reviewed
Jul 9, 2019
junedkazi
reviewed
Jul 9, 2019
junedkazi
reviewed
Jul 9, 2019
junedkazi
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to be the FE version of this helper:
bigcommerce/paper-handlebars#42
When we get stencil image URLs from FE calls, this utils function can generate a srcset string from them.
Added tests for both the new
imageSrcset.getSrcsetand legacyimage.getSrcmethods.