Callback with error on getCartQuantity method #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team |
mattolson
reviewed
Dec 3, 2018
bookernath
force-pushed
the
fix-qty-callback
branch
from
c2d9a85
to
ba311b6
Compare
bookernath
force-pushed
the
fix-qty-callback
branch
from
ba311b6
to
0b4de88
Compare
mattolson
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattolson pointed out that we should have made this error-first, so I'm updating that.
Unfortunately, this breaks the interface for this function, requiring a 3.0; chances are very few people are affected by this, but you can't be too careful.