Extended cli tool to publish widgets across multiple channels #120
+119
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct validate command options
Add translations support to start and publish commands
Replace tracking with publish checks
|
Hi @bc-0dp @joeward98 Sorry for the delayed review. Code looks good. Could you please rebase so I can approve? Thanks! |
|
@bc-0dp nothing I can do, I just linked to related PR's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
For Focusrite, we need multiple BC instances each with multiple storefronts. This means we need to be able to deploy widgets to channels other than the default (channel_id=1)
Testing / Proof
...