EnvelopeFrom Domain cannot be extracted for SA 3.4.2 (SPF alignment fails)

[ouvtam]

SpamAssassin 3.4 does not support the special tag ":host" when extracting the sender domain in
$pms->get('EnvelopeFrom:host', undef)

spamassassin-dmarc/Dmarc.pm

Line 235 in 1749ee8

$mfrom_domain = $pms->get('EnvelopeFrom:host', undef);

Same goes for $pms->get('From:domain', undef);

spamassassin-dmarc/Dmarc.pm

Line 237 in 1749ee8

$mfrom_domain = $pms->get('From:domain', undef);

[ouvtam]

Thanks for confirming and fixing the bug.

In general, it would make sense NOT to fall back to 'From:domain' when no sender is available. Otherwise SPF always aligns and DMARC check can be circumnavigated.

Having a null sender should only pass DMARC if DKIM is valid/aligned or SPF HELO is valid/aligned.