-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and test clang format options; append style.md details #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor questions, but this is probably good enough to have a discussion.
doc/style.md
Outdated
|
||
#include <fmt.h> | ||
#include "my_class_impl.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates the file naming rule above.
doc/style.md
Outdated
* Do use names that are | ||
* descriptive | ||
* intention-revealing | ||
* self-documenting | ||
* pronounceable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should maybe be across all names (not just variable names?)
Looks good to me. Thank you. |
Description
Replace the content in this section with:
Author Progress Checklist:
Reviewer Checklist: