Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sender class improvements #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sender class improvements #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
347b685
Make it impossible to not define class_name for Sender class.
nealkruis May 27, 2024
aceb9a6
Make setters/getters public.
nealkruis May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions include/courier/helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,14 @@ class DefaultCourier : public Courier {
class Sender {
public:
Sender() = default;
explicit Sender(std::string name_in,
explicit Sender(std::string class_name_in,
std::string name_in,
const std::shared_ptr<Courier>& courier_in = std::make_shared<DefaultCourier>())
: name(std::move(name_in)), courier(courier_in) {};
: name(std::move(name_in)), courier(courier_in), class_name(std::move(class_name_in)) {};
std::string name;
void set_courier(const std::shared_ptr<Courier>& courier_in) { courier = courier_in; }
std::shared_ptr<Courier> get_courier() { return courier; }
void set_parent_pointer(Sender* parent_pointer_in) { parent_pointer = parent_pointer_in; }

protected:
std::shared_ptr<Courier> courier;
Expand Down
10 changes: 2 additions & 8 deletions test/library.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,16 @@
#include <courier/helpers.h>
#include <fmt/format.h>

class LibraryClass : Courier::Sender {
class LibraryClass : public Courier::Sender {
public:
explicit LibraryClass(std::string name_in,
const std::shared_ptr<Courier::Courier>& courier_in =
std::make_shared<Courier::DefaultCourier>())
: Courier::Sender(std::move(name_in), courier_in)
: Courier::Sender("LibraryClass", std::move(name_in), courier_in)
{
class_name = "LibraryClass";
}
void generate_debug() { send_debug("Something for the developer happened."); }
void generate_info() { send_info("Something you should notice happened."); }
void generate_warning() { send_warning("Something unexpected happened."); }
void generate_error() { send_error("Something serious happened."); }
void set_courier(std::shared_ptr<Courier::Courier> courier_in)
{
courier = std::move(courier_in);
}
std::shared_ptr<Courier::Courier> get_courier() { return courier; }
};
Loading