This repository has been archived by the owner on Aug 29, 2022. It is now read-only.
Revamped progress calculation around Task and andThen #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Working towards #260.
Tasks created with custom progress and tasks returned from
andThen
with custom progress count for a unit count of 100.Considering @piercifani's code from #260:
We have one initial
Task
with four calls toandThen
.At the moment the above code returns, this will now look like:
Then, let's say
startY
creates aProgress
of its own. That'll look like:Then, the last bits will trickle in:
Testing
Task progress reporting now has 100% test coverage.
URLSessionTask
"-in-the-middle test, like the example aboveURLSessionTask
"-at-the-beginning test, like from Improves progress percent calculation #259 (ping @DrewFitz for a manual test against this branch).API Changes
No public API changes, all under the hood bug fixes and cleanups.