This repository has been archived by the owner on Aug 29, 2022. It is now read-only.
Backpedal on hoisting Task.Result out of Task #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwaldowski
force-pushed
the
zwaldowski/back-result
branch
from
903dac5
to
a013e10
Compare
zwaldowski
force-pushed
the
zwaldowski/back-result
branch
from
a013e10
to
011af7c
Compare
Revert "Move Task.Result back out to TaskResult" fd2faf8
zwaldowski
force-pushed
the
zwaldowski/back-result
branch
from
011af7c
to
3ec76c6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Reverts changes from #243. While they were intended to make code cleaner after adopting Deferred 4.0, with
Swift.Resulton the horizon, forcing two sets of upgrades over the next year is silly. This PR and #271 want to make this as painless as possible.Testing
No changes.
API Changes
Returns to some 3.0 behavior to limit source changes.