Improved Leveling Corner menu #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisslorand
added a commit
to kisslorand/BIGTREETECH-TFT
that referenced
this pull request
May 12, 2022
kisslorand
added a commit
to kisslorand/BIGTREETECH-TFT
that referenced
this pull request
May 21, 2022
mehmetsutas
pushed a commit
to mehmetsutas/BIGTREETECH-TouchScreenFirmware
that referenced
this pull request
May 24, 2022
|
@digant73, your edit is working, but the newly set value will not be saved. |
|
But the feature has nothing to save (even in the past). There was an issue that was fixed by PR #2525 |
|
OK, it's working anyway. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPROVEMENTS:
max(probe offset X, probe offset Y) + 1then a warning popup message is displayed asking to use the safe min value given bymax(probe offset X, probe offset Y) + 1. The default edge distance (set when entering in the menu) is given bymax(level_edge_distance, max(probe offset X, probe offset Y) + 1)wherelevel_edge_distanceis set inconfig.ini. Furthermore, when exiting from the menu the original edge distance value (for Manual Leveling menu) is restored.resolves #2516
PR STATE: Ready for merge.