Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Angular v12 #63

Merged
merged 1 commit into from
May 22, 2021
Merged

feat: support Angular v12 #63

merged 1 commit into from
May 22, 2021

Conversation

dianjuar
Copy link
Member

@dianjuar dianjuar commented May 21, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://www.conventionalcommits.org/en/v1.0.0/
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Both workspaces were tested Angular an Nx

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Chore
  • Refactoring (no functional changes, no api changes)
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Support for AngularV12

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Heavily inspired on Angular Fire

@dianjuar dianjuar marked this pull request as draft May 21, 2021 02:59
@dianjuar dianjuar marked this pull request as ready for review May 22, 2021 06:40
@dianjuar
Copy link
Member Author

@JohannesHoppe my tests are done, everything works as expected.

ngx-deploy-starter can be updated too using this as reference.

@dianjuar dianjuar merged commit 173ce49 into master May 22, 2021
@dianjuar dianjuar deleted the support-v12 branch May 22, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant