Feat/deployment trigger and keep parameters #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default delete all deployments. If keep is specified keep the assigned number of deployments by slicing the filtered deployments list. In order to test the action locally avoid using kebab case for input name to allow POSIX compliant environment variables. I.e. use deployment_trigger instead of deployment-trigger so we can write INPUT_DEPLOYMENT_TRIGGER while testing or running in Docker. Signed-off-by: Snorre Magnus Davøen <snorre.magnus.davoen@adventuretech.no>
snorremd
force-pushed
the
feat/deployment-trigger-and-keep-parameters
branch
from
a4868bc to
604a392
Compare
snorremd
commented
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improvement on @zaosoula's PR: #25.
The PR allows users of the GitHub action to delete deployments for any deployment trigger type, be it
github:pushorad_hoc.Additionally the action will now allow users to specify the number of deployments to
keep. This input variable will default to 0 in which case we add the?force=trueparameter to theDELETEHTTP requests to Cloudflare. This allows deleting also the last deployment for a given branch/alias.Because environment variables are used to test the action locally with correct input values each input name should be encodable as a POSIX compliant environment variable. I've therefore renamed
deployment-triggertodeployment_trigger.Credit to @zaosoula for the initial work on this. ❤️