desktop/game_mode: Use i32 for pid
#234
Conversation
| @@ -154,7 +154,7 @@ impl<'a> GameMode<'a> { | |||
| /// See also [`RegisterGame`](https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.GameMode.html#org-freedesktop-portal-gamemode-registergame). | |||
| #[doc(alias = "RegisterGame")] | |||
| pub async fn register(&self, pid: u32) -> Result<(), Error> { | |||
| let status = self.0.call("RegisterGame", &(pid)).await?; | |||
| let status = self.0.call("RegisterGame", &(pid as i32)).await?; | |||
There was a problem hiding this comment.
why not replace the function signature? is this in order to have a backportable variant?
There was a problem hiding this comment.
Originally, I had two reasons not to change the signature:
- Backward compatibility, in order not to break code that already uses
u32. (Now writing this I realized that probably no one uses it as it doesn't work...) - Better interoperability with Rust, as Rust uses
u32for pids: https://doc.rust-lang.org/std/process/fn.id.html, https://doc.rust-lang.org/std/process/struct.Child.html#method.id
There was a problem hiding this comment.
Right, in such case I would add
// Matches the type used in std
pub type Pid = u32;
and pass that to the functions instead.
There was a problem hiding this comment.
Sure thing, added the Pid type alias and replaced most pids in API. There are instances where u64 is used though, but I haven't touched them.
Let me know if that's what you meant.
The Pid type alias ensures that the proper type is used for pids (u32), which is the same as used by std.
kjarosh
force-pushed
the
gamemode-pid-i32
branch
from
ef34450
to
46678ac
Compare
As per the documentation, methods which accept pids (e.g. RegisterGame, RegisterGameByPid) require the type of pid to be i (i32), not u (u32). Using u32 causes errors in runtime, making these methods unusable. This bug was most likely introduced by ae81250.
kjarosh
force-pushed
the
gamemode-pid-i32
branch
from
46678ac
to
536110a
Compare
|
Do you think we could get a release on |
sure, later this week |
|
Great, thanks! |
|
(a polite bump on this 😶 ) |
|
ah, sorry, completely forgot about it. let me do a release now |
|
No worries, thanks a lot! |
|
0.9.2 should be up |
|
Awesome, that was quick! ^^ |
As per the documentation, methods which accept pids (e.g.
RegisterGame,RegisterGameByPid) require the type of pid to bei(i32), notu(u32).Using
u32causes errors in runtime, making these methods unusable. This bug was most likely introduced by ae81250.See https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.GameMode.html