Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recently added "fs" module to read config.json is not defined. #135

Closed
willpetty opened this issue Jun 12, 2019 · 1 comment
Closed

Recently added "fs" module to read config.json is not defined. #135

willpetty opened this issue Jun 12, 2019 · 1 comment

Comments

@willpetty
Copy link

Looks like the fs module needs to be 'require'-ed in server/app.js. Otherwise it fails to read the config and says "fs is not defined"
@billchurch
Copy link
Owner

Thanks, not sure how i missed that, i guess that's what i get for gracefully handling errors during my tests.

billchurch added a commit that referenced this issue Jun 13, 2019
@billchurch
Missing require('fs') in server/app.js See issue [#135](../../issue…
56086b0 
…s/135)

- Missing require('fs') in `server/app.js` See issue [#135](../../issues/135)
- Patched read-config to mitigate vulnerability in js-yaml
  - issue not exploitable on webssh2 implementation
  - patched anyway
  - sending my patch upstream to read-config, webssh2 package.json points to patched version in my repository https://github.com/billchurch/nodejs-read-config
  - See nodeca/js-yaml#475 for more detail
@billchurch billchurch mentioned this issue Nov 15, 2019
Closed
hktalent pushed a commit to hktalent/webssh2 that referenced this issue Jun 3, 2022
@billchurch
add missing fs
9eabaec 
that was embarassing... fixes billchurch#135
hktalent pushed a commit to hktalent/webssh2 that referenced this issue Jun 3, 2022
@billchurch
Missing require('fs') in server/app.js See issue [billchurch#135](.…
8caff42 
…./..billchurch/issues/135)

- Missing require('fs') in `server/app.js` See issue [billchurch#135](../..billchurch/issues/135)
- Patched read-config to mitigate vulnerability in js-yaml
  - issue not exploitable on webssh2 implementation
  - patched anyway
  - sending my patch upstream to read-config, webssh2 package.json points to patched version in my repository https://github.com/billchurch/nodejs-read-config
  - See nodeca/js-yaml#475 for more detail
hktalent pushed a commit to hktalent/webssh2 that referenced this issue Jun 3, 2022
@billchurch
add missing fs
15b4ad8 
that was embarassing... fixes billchurch#135
hktalent pushed a commit to hktalent/webssh2 that referenced this issue Jun 3, 2022
@billchurch
Missing require('fs') in server/app.js See issue [billchurch#135](.…
a8c8b7e 
…./..billchurch/issues/135)

- Missing require('fs') in `server/app.js` See issue [billchurch#135](../..billchurch/issues/135)
- Patched read-config to mitigate vulnerability in js-yaml
  - issue not exploitable on webssh2 implementation
  - patched anyway
  - sending my patch upstream to read-config, webssh2 package.json points to patched version in my repository https://github.com/billchurch/nodejs-read-config
  - See nodeca/js-yaml#475 for more detail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@billchurch @willpetty