Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VENTILATION climateControlState #648

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

DatDraggy
Copy link
Contributor

@DatDraggy DatDraggy commented Aug 22, 2024

Proposed change

There currently is no constant to reflect the "VENTILATION" state, resulting in it defaulting to "Unknown". It's the climatization function that's toggleable via the api while the car is off.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Currently there's no translation for VENTILATION, I'm new to contributions so I'm unsure if this is on the HA translation team or if this is something I have to add somewhere.

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@DatDraggy
Copy link
Contributor Author

Is a dedicated test necessary? I tested it locally and it displays fine, just the translation is missing for HA.
I can provide a fingerprint with the functionality active if needed.

@DatDraggy DatDraggy marked this pull request as ready for review August 22, 2024 11:16
@DatDraggy
Copy link
Contributor Author

@rikroe
Copy link
Member

rikroe commented Aug 24, 2024

Many thanks!

HA translation will need to be adjusted once the lib update gets merged.

@rikroe rikroe merged commit 2487964 into bimmerconnected:master Aug 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants