Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle captcha in North America #665

Merged
merged 6 commits into from
Nov 3, 2024
Merged

Handle captcha in North America #665

merged 6 commits into from
Nov 3, 2024

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Nov 1, 2024

Breaking change

BMW API for North America now requires a captcha to be solved. The token needs to be used during first init of MyBMWAccount(..., hcaptcha_token=TOKEN) or with the --captcha-token CLI parameter. See the documentation for more information.
This does only apply when using the library outside Home Assistant.

Proposed change

Fix the login. Only required when not using the refresh_token flow.
Unfortunatly, this requires a manual intervention on the first login (or after any failed login attempt).

Once merged to master and a build is on readthedocs, I'll double check if the links are working as expected.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe requested a review from gerard33 November 2, 2024 10:15
Copy link
Member

@gerard33 gerard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍🏻

@rikroe rikroe merged commit eb06aea into master Nov 3, 2024
11 checks passed
@johnwalk61
Copy link

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Authentication Failed
3 participants