Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace proc-macro-error #4

Closed
max-sixty opened this issue Apr 17, 2024 · 3 comments
Closed

Replace proc-macro-error #4

max-sixty opened this issue Apr 17, 2024 · 3 comments

Comments

@max-sixty
Copy link

Currently the only dependency that use syn v1 in PRQL's dependencies is from test-each-file. Given how large syn is, this slows down our compile times.

I think that's from proc-macro-error, which isn't maintained:

$ cargo tree -i syn@1

syn v1.0.109
└── proc-macro-error v1.0.4
    └── test_each_file v0.3.1 (proc-macro)

I think there are some replacements for that crate — to the extent it's possible, could that it be replaced?

@JonathanBrouwer
Copy link
Contributor

That's a good point. I'm going to take a look at how feasible replacing this dependency is tonight

@Vlamonster
Copy link
Contributor

Issue is resolved in version 0.3.2.

@max-sixty
Copy link
Author

Thanks @Vlamonster !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants