Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect prunable application stores #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sigv
Copy link

@sigv sigv commented Sep 27, 2024

This removes various dependencies, making the project slimmer, while at the same time allowing it to be more portable across chains (without having to hard-code them). This furthermore eliminates human effort needed at chain upgrades, which may add or remove specific application.db stores.

Worth noting, removal of github.com/cosmos/cosmos-sdk/x/consensus/types package import:

This removes various dependencies, making the project slimmer,
while at the same time allowing it to be more portable across
chains (without having to hard-code them). This furthermore
eliminates human effort needed at chain upgrades, which may add
or remove specific application.db stores.
@sigv
Copy link
Author

sigv commented Sep 27, 2024

This PR adds rootmulti.GetCommitInfo to keep the change scope as straight-forward as possible.
Upstream Cosmos SDK has already made this function publicly usable in cosmossdk.io/store.

The function added by PR is compatible with the function signature resulting from future rootmulti updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant