Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2 #33

Merged
merged 75 commits into from
Jun 16, 2024
Merged

v1.2 #33

merged 75 commits into from
Jun 16, 2024

Conversation

Croydon
Copy link
Member

@Croydon Croydon commented Nov 1, 2022

Deprecations

  • If there is ever going to be another bigger update of Bincrafters Conventions then
    • all logic regarding updating Travis and AppVeyor CI files to a newer revision will be removed
    • The min required Conan version will be raised from 1.53.0 to 1.64.1
    • Checks would probably be removed as Conan hooks and/or extensions are much better suited for this

New Features

  • Add new, much more intelligent way to update imports in Conanfiles. Currently, the following update rules exist:
    • Migrate from conans.model.version import Version -> from conans.tools import Version (Conan >= 1.15 <2) to new updater
    • Add from conans.tools import Version -> from conan.tools.scm import Version (Conan >= 1.46)
    • Migrate from conans.erros import X -> from conan.errors import X (Conan >= 1.47) to new updater

Improvements

  • Add some reference updates
  • Update OpenSSL patch levels to 1.1.1w (end-of-life), 3.0.14, 3.1.6, 3.2.2

Internal

  • CI: run tests with both Conan v1 and Conan v2; run tests in more environments (different OS versions + Python 3.11 in addition to 3.8); update some environments for some jobs
  • More general CI changes
  • Python: Migrate most string.format()s to f-strings
  • Reference updates: Move data from in-source to dedicated YAML files
  • Some preparations for Conan 2.x support

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Attention: Patch coverage is 91.14391% with 24 lines in your changes missing coverage. Please review.

Project coverage is 88.81%. Comparing base (a43277f) to head (501db73).
Report is 1 commits behind head on main.

Files Patch % Lines
bincrafters_conventions/bincrafters_conventions.py 72.41% 8 Missing ⚠️
bincrafters_conventions/compat/subapi/local.py 56.25% 7 Missing ⚠️
...incrafters_conventions/actions/update_c_imports.py 96.46% 4 Missing ⚠️
...ntions/actions/update_c_default_options_to_dict.py 85.71% 3 Missing ⚠️
...ers_conventions/actions/check_for_download_hash.py 66.66% 1 Missing ⚠️
bincrafters_conventions/compat/__init__.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   87.38%   88.81%   +1.42%     
==========================================
  Files          27       29       +2     
  Lines         872     1010     +138     
==========================================
+ Hits          762      897     +135     
- Misses        110      113       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Croydon Croydon force-pushed the dev/1-2 branch 3 times, most recently from d86d05b to a4d530e Compare March 7, 2023 19:36
@Croydon Croydon marked this pull request as ready for review June 16, 2024 23:31
@Croydon Croydon merged commit d1ade75 into main Jun 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants