Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdstream support #168

Merged
merged 9 commits into from
Sep 18, 2024
Merged

stdstream support #168

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
441b21b
stdstream support
ezrizhu Jul 10, 2024
c16e7e1
name /dev/stdstream files directly
ezrizhu Jul 19, 2024
b02f867
remove quotes in heredoc
ezrizhu Jul 19, 2024
9f99f7a
improve stdstream test
ezrizhu Aug 5, 2024
fb8f29b
shellcheck
ezrizhu Aug 5, 2024
ef2f1f1
Merge branch 'main' into stdstream
ezrizhu Aug 22, 2024
8601a70
use files
ezrizhu Sep 6, 2024
be0d6aa
shellcheck and use grep instead of diff
ezrizhu Sep 6, 2024
af57a02
fd test
ezrizhu Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions test/stdstream.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,23 @@ TRY="$TRY_TOP/try"

cmdfile="$(mktemp)"

cat > "$cmdfile" <<EOF
file /dev/stdin
file /dev/stdout
file /dev/stderr
cat > "$cmdfile" <<'EOF'
read x < /dev/stdin
ezrizhu marked this conversation as resolved.
Show resolved Hide resolved
echo $((x * 2)) > /dev/stdout
echo $((x * 3)) > /dev/stderr

EOF

chmod +x "$cmdfile"

result=$("$TRY" "$cmdfile")
expected=$(sh "$cmdfile")
# test stdout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not test for exact output from both at once by capturing output in mktemped files?

result=$(echo 5 | "$TRY" "$cmdfile" 2>/dev/null)
expected=$(echo 5 | sh "$cmdfile" 2>/dev/null)

[ "$result" = "$expected" ] || exit 1

# test stdout + stderr
result=$(echo 5 | "$TRY" "$cmdfile" 2>&1)

# using grep because stdout also includes try err/warns
echo $result | grep 15 > /dev/null
Loading