-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Compare enum for the index query #44
Conversation
Actually, looking at the
to |
…ethods the same (they have inambiguous signatures)
@eparejatobes
Look, I've added here two enums, which are equivalent to the Tinkerpop or Titan ones. When you write code with bio4j/angulillos, you either use backend's query mechanism or these methods in the import org.apache.tinkerpop.gremlin.process.traversal.Compare;
GoGraph().goTermIdIndex().query(Compare.eq, "ID12345"); or import com.bio4j.angulillos.QueryPredicate.Compare;
GoGraph().goTermIdIndex().query(Compare.EQUAL, "ID12345"); Then if you use bio4j-titan, it also doesn't matter to you, because both things will be converted to I think that it is quite important to keep angulillos-core dependencies-free (without real need), while angulillos-titan is going to depend on it anyway, just because titan-core does. |
@laughedelic fair enough. |
* Removed blueprints dependency (now angulillos is dependency-free 🎉): - #36: Using Java 8 `BiPredicate` instead of the `blueprints.Predicate` - #44: Added `Compare` and `Contain` query predicate enums and corresponding `query` methods to the `TypedElementIndex` interface * Other minor changes: added `name`, `graph` and `elementType` to the `TypedElementIndex` interface
In #36 it was removed from the
query
method. See bio4j/angulillos-titan#17 (comment).Compare
(which was used here)Compare
Cmp
which are all basically the same thing. I'm going to add here the same thing and in angulillos-titan convert it to the Titan's
Cmp
.