Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all arity-specific methods are broken #78

Merged
merged 3 commits into from
Jun 8, 2016

Conversation

eparejatobes
Copy link
Member

No description provided.

@laughedelic
Copy link
Member

😱

@laughedelic
Copy link
Member

What happened?

@eparejatobes
Copy link
Member Author

just pushed

@eparejatobes
Copy link
Member Author

EdgeType needs to refer to itself in TypedGraph, otherwise you just know about it source and target. This is wrong:

> extends Element<E, EdgeType<S,E,T>, RE>
implements TypedEdge<
S, VertexType<S>,
E, EdgeType<S,E,T>,
T, VertexType<T>,
G,RV,RE
> {
protected Edge(RE raw, EdgeType<S,E,T> type) { super(raw, type); }
}
public abstract class EdgeType<
S extends Vertex<S>,
E extends Edge<S,E,T>,
T extends Vertex<T>
> extends ElementType<E, EdgeType<S,E,T>, RE>
implements TypedEdge.Type<
S, VertexType<S>,
E, EdgeType<S,E,T>,

@eparejatobes
Copy link
Member Author

That, or making on EdgeType class per Arity combination in TypedGraph

@eparejatobes
Copy link
Member Author

There's a super-easy unsafe fix though, that could be enough

@eparejatobes
Copy link
Member Author

@laughedelic doing this? if not, will do

@laughedelic
Copy link
Member

laughedelic commented Jun 8, 2016

So what's your plan?

@eparejatobes
Copy link
Member Author

to fix it!

@eparejatobes eparejatobes merged commit fac9441 into master Jun 8, 2016
@eparejatobes eparejatobes deleted the bug/arity/methods/broken/78 branch June 8, 2016 15:57
eparejatobes added a commit that referenced this pull request Jun 8, 2016
This release fixes #78, which made impossible to use arity-specific methods (inOneV, outAtMostOneV, ...) when using TypedGraph inner classes. Everyone should update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants