Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on points to reveal label #327

Closed
lkursell opened this issue Jan 13, 2015 · 8 comments
Closed

Click on points to reveal label #327

lkursell opened this issue Jan 13, 2015 · 8 comments

Comments

@lkursell
Copy link

Sometimes the cluster of points is too dense to distinguish an individual point's label when the labels are all turned on. Would be nice to be able to click on one point and have the label appear, perhaps at the bottom of the PCoA plot, like what happened in KiNG

@antgonza
Copy link
Collaborator

Agree, have you tried playing with the transparency of the points?

@lkursell
Copy link
Author

That helps some, and with that + zooming the answer is eventually retrievable…though this is not pretty to look at:

On Jan 13, 2015, at 11:23 AM, Antonio Gonzalez notifications@github.com wrote:

Agree, have you tried playing with the transparency of the points?

Reply to this email directly or view it on GitHub #327 (comment).

@wasade
Copy link
Member

wasade commented Jan 13, 2015

This would be awesome but just so you're aware, it is potentially
challenging to implement. Hit boxes are surprisingly tedious to resolve and
may require data structure changes to put in place.
On Jan 13, 2015 7:23 PM, "Antonio Gonzalez" notifications@github.com
wrote:

Agree, have you tried playing with the transparency of the points?


Reply to this email directly or view it on GitHub
#327 (comment).

@lkursell
Copy link
Author

No worries, and thanks for the insight, Antonio’s suggestion worked

On Jan 13, 2015, at 11:29 AM, Daniel McDonald notifications@github.com wrote:

This would be awesome but just so you're aware, it is potentially
challenging to implement. Hit boxes are surprisingly tedious to resolve and
may require data structure changes to put in place.
On Jan 13, 2015 7:23 PM, "Antonio Gonzalez" notifications@github.com
wrote:

Agree, have you tried playing with the transparency of the points?


Reply to this email directly or view it on GitHub
#327 (comment).


Reply to this email directly or view it on GitHub #327 (comment).

@ElDeveloper
Copy link
Member

👍 on that this issue should be resolved! When I get some time I'll
try having a look and see how problematic this may be to implement.

On (Jan-13-15|10:35), Luke Ursell wrote:

No worries, and thanks for the insight, Antonio’s suggestion worked

On Jan 13, 2015, at 11:29 AM, Daniel McDonald notifications@github.com wrote:

This would be awesome but just so you're aware, it is potentially
challenging to implement. Hit boxes are surprisingly tedious to resolve and
may require data structure changes to put in place.
On Jan 13, 2015 7:23 PM, "Antonio Gonzalez" notifications@github.com
wrote:

Agree, have you tried playing with the transparency of the points?


Reply to this email directly or view it on GitHub
#327 (comment).


Reply to this email directly or view it on GitHub #327 (comment).


Reply to this email directly or view it on GitHub:
#327 (comment)

@clozupone
Copy link

Hey, what is the current status of this issue? This is the one functionality that I really miss from KING. Particularly with a large dataset, it is nearly impossible to tell from labels what sample a point represents.

@rob-knight
Copy link

+1

On Aug 31, 2015, at 1:57 PM, clozupone notifications@github.com wrote:

Hey, what is the current status of this issue? This is the one functionality that I really miss from KING. Particularly with a large dataset, it is nearly impossible to tell from labels what sample a point represents.


Reply to this email directly or view it on GitHub #327 (comment).

@ElDeveloper ElDeveloper mentioned this issue Sep 2, 2015
20 tasks
@ElDeveloper
Copy link
Member

@clozupone we are doing a major refactoring at the moment (see #405), I've added this feature request as part of the points that must be covered, more updates soon.

squirrelo added a commit to squirrelo/emperor that referenced this issue May 16, 2016
squirrelo added a commit to squirrelo/emperor that referenced this issue May 17, 2016
clean up

remove extra var instantiation

use on function

clean up code

make offset work for notebooks

remove fadein

make duration variable
ElDeveloper added a commit that referenced this issue May 17, 2016
squirrelo added a commit to squirrelo/emperor that referenced this issue May 27, 2016
add scaling for non-numeric only

recolor non-numeric values

address comments

break out plottables and add tests

add vertical colorbar

fix slickgrid height issue

cleaner resize for svg

single pass numeric check

update tests

hide non-numeric color set if none exist

fix scale issues

fix slickgrid canvas size

fix load issue

fix resize issue

change percent height

add teste for fromJSON

change deepEqual to equal

add end tag for linearGradient

fixed bixel size resize

resize body manually before super call

address comments

replace removed line break

add splashscreen

update test string

remove extra css

Use alt text to show missing resources message. Fixes biocore#424

fix test string

only render orbitcontrol on change

re-render on resize

render only on decView changes as well

add clarifying comment. Fixes biocore#164

condense checks to sceneplotview3d

address comments

set re-render needed on per sceneview basis

render on per-scene basis

add tests for setting needsUpdate and checking needsUpdate

address comments

initial info visualization

remove logging. Fixes biocore#327

clean up

remove extra var instantiation

use on function

clean up code

make offset work for notebooks

remove fadein

make duration variable
squirrelo added a commit to squirrelo/emperor that referenced this issue May 31, 2016
add scaling for non-numeric only

recolor non-numeric values

address comments

break out plottables and add tests

add vertical colorbar

fix slickgrid height issue

cleaner resize for svg

single pass numeric check

update tests

hide non-numeric color set if none exist

fix scale issues

fix slickgrid canvas size

fix load issue

fix resize issue

change percent height

add teste for fromJSON

change deepEqual to equal

add end tag for linearGradient

fixed bixel size resize

resize body manually before super call

address comments

replace removed line break

add splashscreen

update test string

remove extra css

Use alt text to show missing resources message. Fixes biocore#424

fix test string

only render orbitcontrol on change

re-render on resize

render only on decView changes as well

add clarifying comment. Fixes biocore#164

condense checks to sceneplotview3d

address comments

set re-render needed on per sceneview basis

render on per-scene basis

add tests for setting needsUpdate and checking needsUpdate

address comments

initial info visualization

remove logging. Fixes biocore#327

clean up

remove extra var instantiation

use on function

clean up code

make offset work for notebooks

remove fadein

make duration variable

automatic gjslint

BUG: Add missing _ dependency

Noticed this while trying to load a gist, it seems like "most times"
browsers load underscore.js.

MAINT: Remove emperor.js

It's been a good run! 💔

remove ui.js and tests for it

BLD/TST: Fix problems with miniconda in travis

update jquery, bootstrap, and add link to jsdocs

clean up menu a bit

install jsdoc in travis

update animate.js

add missing property docs

update docs for view-controller.js

pass gjslint tests

address comments

start on docs updates

finish update for gjslint

remove module declaration

add missing *

for update purposes

formatting

install and build jsdocs in travis

update settings for linting and doc creation

Fix @ElDeveloper's comments

change reference path to jsdoc config file

update docstrings and gjslint for util

fix gjslint issue

update contributing and readme for javascript info

add text about custom JSDoc tags for linter

formatting

add links to the linters

update sceneplotview3d for jsdoc and gjslint compliance

reorder for proper rendering

DOC: Add docs for color editor & formatter

DOC: Add documentation for model.js

DOC/STY: Adds necessary jsdoc and fixes gjslint

I've also renamed buildUI to _buildUI, because it shouldn't be a method
that's publicly used.

DOC: Add documentation for DecompositionView

update gjslint and jsdoc for visibility-controller.js

fix return value

upadate trajectory.js docs

address comments

update ddraw.js for gjslint and jsdoc

update draw.js for gjslint and jsdoc

address comment

update shape-controller.js to comply with gjslint and jsdocs

update surrounding files of shape controller for gjslint and jsdocs

move the stars

DOC: Address @squirrelo's comments

STY: Fix test_draw.js

STY: Fix test_plottable.js

STY: Fix test_sceneplotview3d.js

STY: Fix test_shape_controller.js

STY: Fix test_trajectory.js

STY: Fix test_util.js

STY: Fix test_view_controller.js

STY: Fix test_visibility_controller.js

STY: Fix test_decomposition_view.js

STY: Fix test_decomposition_model.js

add @see to colorviewcontroller

fix runner.js

fix test_animate

gjslint compliance

update shape-editor to render correctly in module

add @see to mroe files

squash last linter problems

clean up more

fix runner.js

fix for gjslint
squirrelo added a commit to squirrelo/emperor that referenced this issue May 31, 2016
add scaling for non-numeric only

recolor non-numeric values

address comments

break out plottables and add tests

add vertical colorbar

fix slickgrid height issue

cleaner resize for svg

single pass numeric check

update tests

hide non-numeric color set if none exist

fix scale issues

fix slickgrid canvas size

fix load issue

fix resize issue

change percent height

add teste for fromJSON

change deepEqual to equal

add end tag for linearGradient

fixed bixel size resize

resize body manually before super call

address comments

replace removed line break

add splashscreen

update test string

remove extra css

Use alt text to show missing resources message. Fixes biocore#424

fix test string

only render orbitcontrol on change

re-render on resize

render only on decView changes as well

add clarifying comment. Fixes biocore#164

condense checks to sceneplotview3d

address comments

set re-render needed on per sceneview basis

render on per-scene basis

add tests for setting needsUpdate and checking needsUpdate

address comments

initial info visualization

remove logging. Fixes biocore#327

clean up

remove extra var instantiation

use on function

clean up code

make offset work for notebooks

remove fadein

make duration variable

automatic gjslint

BUG: Add missing _ dependency

Noticed this while trying to load a gist, it seems like "most times"
browsers load underscore.js.

MAINT: Remove emperor.js

It's been a good run! 💔

remove ui.js and tests for it

BLD/TST: Fix problems with miniconda in travis

update jquery, bootstrap, and add link to jsdocs

clean up menu a bit

install jsdoc in travis

update animate.js

add missing property docs

update docs for view-controller.js

pass gjslint tests

address comments

start on docs updates

finish update for gjslint

remove module declaration

add missing *

for update purposes

formatting

install and build jsdocs in travis

update settings for linting and doc creation

Fix @ElDeveloper's comments

change reference path to jsdoc config file

update docstrings and gjslint for util

fix gjslint issue

update contributing and readme for javascript info

add text about custom JSDoc tags for linter

formatting

add links to the linters

update sceneplotview3d for jsdoc and gjslint compliance

reorder for proper rendering

DOC: Add docs for color editor & formatter

DOC: Add documentation for model.js

DOC/STY: Adds necessary jsdoc and fixes gjslint

I've also renamed buildUI to _buildUI, because it shouldn't be a method
that's publicly used.

DOC: Add documentation for DecompositionView

update gjslint and jsdoc for visibility-controller.js

fix return value

upadate trajectory.js docs

address comments

update ddraw.js for gjslint and jsdoc

update draw.js for gjslint and jsdoc

address comment

update shape-controller.js to comply with gjslint and jsdocs

update surrounding files of shape controller for gjslint and jsdocs

move the stars

DOC: Address @squirrelo's comments

STY: Fix test_draw.js

STY: Fix test_plottable.js

STY: Fix test_sceneplotview3d.js

STY: Fix test_shape_controller.js

STY: Fix test_trajectory.js

STY: Fix test_util.js

STY: Fix test_view_controller.js

STY: Fix test_visibility_controller.js

STY: Fix test_decomposition_view.js

STY: Fix test_decomposition_model.js

add @see to colorviewcontroller

fix runner.js

fix test_animate

gjslint compliance

update shape-editor to render correctly in module

add @see to mroe files

squash last linter problems

clean up more

fix runner.js

fix for gjslint
squirrelo added a commit to squirrelo/emperor that referenced this issue May 31, 2016
add scaling for non-numeric only

recolor non-numeric values

address comments

break out plottables and add tests

add vertical colorbar

fix slickgrid height issue

cleaner resize for svg

single pass numeric check

update tests

hide non-numeric color set if none exist

fix scale issues

fix slickgrid canvas size

fix load issue

fix resize issue

change percent height

add teste for fromJSON

change deepEqual to equal

add end tag for linearGradient

fixed bixel size resize

resize body manually before super call

address comments

replace removed line break

add splashscreen

update test string

remove extra css

Use alt text to show missing resources message. Fixes biocore#424

fix test string

only render orbitcontrol on change

re-render on resize

render only on decView changes as well

add clarifying comment. Fixes biocore#164

condense checks to sceneplotview3d

address comments

set re-render needed on per sceneview basis

render on per-scene basis

add tests for setting needsUpdate and checking needsUpdate

address comments

initial info visualization

remove logging. Fixes biocore#327

clean up

remove extra var instantiation

use on function

clean up code

make offset work for notebooks

remove fadein

make duration variable

automatic gjslint

BUG: Add missing _ dependency

Noticed this while trying to load a gist, it seems like "most times"
browsers load underscore.js.

MAINT: Remove emperor.js

It's been a good run! 💔

remove ui.js and tests for it

BLD/TST: Fix problems with miniconda in travis

update jquery, bootstrap, and add link to jsdocs

clean up menu a bit

install jsdoc in travis

update animate.js

add missing property docs

update docs for view-controller.js

pass gjslint tests

address comments

start on docs updates

finish update for gjslint

remove module declaration

add missing *

for update purposes

formatting

install and build jsdocs in travis

update settings for linting and doc creation

Fix @ElDeveloper's comments

change reference path to jsdoc config file

update docstrings and gjslint for util

fix gjslint issue

update contributing and readme for javascript info

add text about custom JSDoc tags for linter

formatting

add links to the linters

update sceneplotview3d for jsdoc and gjslint compliance

reorder for proper rendering

DOC: Add docs for color editor & formatter

DOC: Add documentation for model.js

DOC/STY: Adds necessary jsdoc and fixes gjslint

I've also renamed buildUI to _buildUI, because it shouldn't be a method
that's publicly used.

DOC: Add documentation for DecompositionView

update gjslint and jsdoc for visibility-controller.js

fix return value

upadate trajectory.js docs

address comments

update ddraw.js for gjslint and jsdoc

update draw.js for gjslint and jsdoc

address comment

update shape-controller.js to comply with gjslint and jsdocs

update surrounding files of shape controller for gjslint and jsdocs

move the stars

DOC: Address @squirrelo's comments

STY: Fix test_draw.js

STY: Fix test_plottable.js

STY: Fix test_sceneplotview3d.js

STY: Fix test_shape_controller.js

STY: Fix test_trajectory.js

STY: Fix test_util.js

STY: Fix test_view_controller.js

STY: Fix test_visibility_controller.js

STY: Fix test_decomposition_view.js

STY: Fix test_decomposition_model.js

add @see to colorviewcontroller

fix runner.js

fix test_animate

gjslint compliance

update shape-editor to render correctly in module

add @see to mroe files

squash last linter problems

clean up more

fix runner.js

fix for gjslint
squirrelo added a commit to squirrelo/emperor that referenced this issue May 31, 2016
clean up

remove extra var instantiation

use on function

clean up code

make offset work for notebooks

remove fadein

make duration variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants