Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add Emperor class #281

Merged
merged 6 commits into from
Jul 28, 2014
Merged

ENH: Add Emperor class #281

merged 6 commits into from
Jul 28, 2014

Conversation

ElDeveloper
Copy link
Member

This class allows an IPython notebook user to display PCoA plots inline and
without struggle. Note that at the moment this object does not support all
the functionality that make_emperor.py does, this will require further
work in the overall structure of the script code. However, it would be super
useful if people started trying this out and pointed out the things that are
the most needed at the moment.

See this notebook (note that NBViewer does some weird things so it is better
to download this notebook and try it on your own):
http://nbviewer.ipython.org/gist/ElDeveloper/24a383b778943a187966

In case you cannot try the notebook, see this image:


HT to the IPython developers that helped me figure this out at SciPy last week
the solution ended up being really nice and provides (I think) a really easy to
use object.

@ElDeveloper
Copy link
Member Author

Just in case I've added an issue to the nbviewer repo jupyter/nbviewer#316

@teravest
Copy link
Contributor

👍 pretty cool

@wasade
Copy link
Member

wasade commented Jul 28, 2014

🚀 ▶️ 🌔

__copyright__ = "Copyright 2013, The Emperor Project"
__credits__ = ["Yoshiki Vazquez Baeza"]
__license__ = "BSD"
__version__ = "0.9.3-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 1.0-dev?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not there yet, though I suspect that we'll get there in the next release (but shhhhhh, it is supposed to be a surprise 🙊 ).

@wasade
Copy link
Member

wasade commented Jul 28, 2014

This is awesome. I don't see any reason to not merge

@ElDeveloper
Copy link
Member Author

If this looks good, then it should be ready to be merged.

wasade added a commit that referenced this pull request Jul 28, 2014
@wasade wasade merged commit ee12881 into biocore:master Jul 28, 2014
@ElDeveloper
Copy link
Member Author

Thanks @teravest & @wasade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants