-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: export plot to vega editor #714
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -525,19 +525,7 @@ define([ | |
decomp = this.decViews[firstKey].decomp; | ||
|
||
this._dimensionsIterator(function(start, end, index) { | ||
// when the labels get too long, it's a bit hard to look at | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moved this into the model that way I could pluck it off in the view (I went back and forth on where the rendering code would live a few times, so this might just be a remnant of an old iteration). |
||
if (decomp.axesNames[index].length > 25) { | ||
text = decomp.axesNames[index].slice(0, 20) + '...'; | ||
} | ||
else { | ||
text = decomp.axesNames[index]; | ||
} | ||
|
||
// account for custom axes (their percentage explained will be -1 to | ||
// indicate that this attribute is not meaningful). | ||
if (decomp.percExpl[index] >= 0) { | ||
text += ' (' + decomp.percExpl[index].toPrecision(4) + ' %)'; | ||
} | ||
text = decomp.axesLabels[index]; | ||
|
||
axisLabel = makeLabel(end, text, color); | ||
axisLabel.scale.set(axisLabel.scale.x * scaling, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -127,6 +127,7 @@ define([ | |
_.each(group, function(element) { | ||
idx = element.idx; | ||
scope.markers[idx].geometry = geometry; | ||
scope.markers[idx].userData.shape = shape; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Track the shape label, that way we can translate to a vega shape later. |
||
}); | ||
scope.needsUpdate = true; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine there is a better way to identify when the plot isn't a biplot or a procrustes plot. The reason I want to disable then is because the spec is not aware of non-point glyphs (yet).