This repository has been archived by the owner on Jul 29, 2020. It is now read-only.
Metadata sync #244
Open
Metadata sync #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josenavas
approved these changes
Aug 22, 2017
knimin/lib/data_access.py
Outdated
| @@ -687,6 +688,9 @@ def format_survey_data(self, md, external_surveys=None, full=False): # noqa | |||
| list of tuple of str | |||
| The barcode and error message if something failed | |||
| """ | |||
| not_provided = 'Not provided' | |||
There was a problem hiding this comment.
I think this needs to be Missing: Not provided:
|
Nope, that value causes TOAST issues with qiita so we did not use it for
whats now in EBI
…On Aug 21, 2017 6:00 PM, "Jose Navas" ***@***.***> wrote:
***@***.**** approved this pull request.
Code looks good - just one comment!
------------------------------
In knimin/lib/data_access.py
<#244 (comment)>:
> @@ -687,6 +688,9 @@ def format_survey_data(self, md, external_surveys=None, full=False): # noqa
list of tuple of str
The barcode and error message if something failed
"""
+ not_provided = 'Not provided'
I think this needs to be Missing: Not provided:
https://github.com/biocore/qiita/blob/6b59f3799faab68c8d7564cdebe367
894794d1d3/qiita_db/metadata_template/constants.py#L74-L75
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#244 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAc8ssBBCDMOqT4-hjDCA4PkQ_lVglTeks5saigugaJpZM4O96_H>
.
|
|
👍 |
|
Max row size
On Aug 21, 2017 7:10 PM, "Jose Navas" <notifications@github.com> wrote:
Thanks for the info @wasade <https://github.com/wasade>! It is weird as
that is the value listed in the website to use. @antgonza
<https://github.com/antgonza> any input on why there was so many problems
using those values?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#244 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAc8svdceuy9MopqbKBtHY714UytWNXIks5sajiPgaJpZM4O96_H>
.
|
|
Will check when I can open laptop again
…On Aug 21, 2017 7:08 PM, "Embriette Hyde" ***@***.***> wrote:
👍
Any idea why the Travis build failed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#244 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAc8stzBQaQZVsWtAN3Zuhic05AshOHOks5sajf5gaJpZM4O96_H>
.
|
|
Some failures are due tests that I didn't catch to fix. Others look unrelated. Updating. |
wasade
commented
Oct 5, 2017
| barcode['COUNTRY'] = country_lookup[country] | ||
| barcode['GEO_LOC_NAME'] = ':'.join( | ||
| [barcode['COUNTRY'], barcode['STATE']]) | ||
| #except KeyError: |
There was a problem hiding this comment.
see note in _integrate_barcode_information
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is good for first round review. Constants are being evaluated out-of-band, please do not merge until I provide a 👍 on that.
cc @josenavas @EmbrietteH