make error message more informative #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one passes a float, let's say -m=2.5G the only message that is returned is: "sambamba-sort: couldn't parse ", which is not very informative, as this someone may blame the input BAM file and spend some time trying to figure out what is wrong with it. The updated error message points directly into the point saving users time.
|
Thanks. Would be good to look at all error messages :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one passes a float, let's say -m=2.5G the only message that is returned is: "sambamba-sort: couldn't parse ", which is not very informative, as this someone may blame the input BAM file and spend some time trying to figure out what is wrong with it. The updated error message points directly to the problem. That's a very little change that may save some time.