-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability for inputting full ForenSeq sequences (not run through UAS) #16
Conversation
Oops... didn't mean to try to merge that... |
We can probably merge this branch into the master, @standage. The other things I want to do are a bit more complicated and will require more time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, pending some minor comments.
I'll merge when the remaining comments are resolved. |
Ok, @standage, I think now it's ready! :) |
I'm having issues with writing the code for this test and thought maybe @standage you could solve it in 5 seconds... When I run the test it's cutting off the header of the file it's creating (and so the test is failing)... thoughts? If I remove the header from the comparison file, the test passes. It's driving me crazy. |
Ok, so I'm seeing that the NamedTemporaryFile() function creates the file immediately (thus lusSTR sees the file exists and doesn't add the header). Is there another way to create a temp file? Or should I just remove the header of the test file? |
I was hoping there was a way to tell So the simplest solution I could come up with, silly as it sounds, is to delete the file before running |
The test suite is passing now, w00t! Do we have any data sets that we can run without the |
yes! Just added the test and all pass for me. |
Adding capability to input full ForenSeq sequences which have not been run through the UAS (#14).
This requires:
Adding CLI (
--uas
flag) for indicating if sequences have been run through the UAS for thelusstr annotate
commandAdding the number of bases to remove from the 5' and 3' ends of the full sequence to the str_markers.json file in order to produce the UAS region of the sequence.
Incorporating code into the annot.py script to remove the 5' and 3' bases to create the sequence of the UAS region (for further annotation).
Create bracketed annotation form of the full sequence.