Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability for inputting full ForenSeq sequences (not run through UAS) #16

Merged
merged 18 commits into from
Apr 28, 2020

Conversation

rnmitchell
Copy link
Contributor

Adding capability to input full ForenSeq sequences which have not been run through the UAS (#14).

This requires:

  • Adding CLI (--uas flag) for indicating if sequences have been run through the UAS for the lusstr annotate command

  • Adding the number of bases to remove from the 5' and 3' ends of the full sequence to the str_markers.json file in order to produce the UAS region of the sequence.

  • Incorporating code into the annot.py script to remove the 5' and 3' bases to create the sequence of the UAS region (for further annotation).

  • Create bracketed annotation form of the full sequence.

@rnmitchell
Copy link
Contributor Author

Oops... didn't mean to try to merge that...

@rnmitchell
Copy link
Contributor Author

We can probably merge this branch into the master, @standage. The other things I want to do are a bit more complicated and will require more time.

@standage standage changed the title WIP: Add capability for inputting full ForenSeq sequences (not run through UAS) Add capability for inputting full ForenSeq sequences (not run through UAS) Apr 24, 2020
Copy link
Member

@standage standage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, pending some minor comments.

lusSTR/str_markers.json Outdated Show resolved Hide resolved
lusSTR/annot.py Outdated Show resolved Hide resolved
lusSTR/annot.py Outdated Show resolved Hide resolved
lusSTR/annot.py Outdated Show resolved Hide resolved
@standage
Copy link
Member

I'll merge when the remaining comments are resolved.

@rnmitchell
Copy link
Contributor Author

Ok, @standage, I think now it's ready! :)

lusSTR/annot.py Outdated Show resolved Hide resolved
@rnmitchell
Copy link
Contributor Author

I'm having issues with writing the code for this test and thought maybe @standage you could solve it in 5 seconds... When I run the test it's cutting off the header of the file it's creating (and so the test is failing)... thoughts? If I remove the header from the comparison file, the test passes. It's driving me crazy.

@rnmitchell
Copy link
Contributor Author

Ok, so I'm seeing that the NamedTemporaryFile() function creates the file immediately (thus lusSTR sees the file exists and doesn't add the header). Is there another way to create a temp file? Or should I just remove the header of the test file?

@standage
Copy link
Member

I was hoping there was a way to tell NamedTemporaryFile to just return a filename without creating the file. There is a mktemp() function, but it is deprecated due to its risk for race conditions.

So the simplest solution I could come up with, silly as it sounds, is to delete the file before running lusSTR annotate.

@standage
Copy link
Member

The test suite is passing now, w00t!

Do we have any data sets that we can run without the --uas flag, so that the resolve_uas_sequence() code gets invoked?

@rnmitchell
Copy link
Contributor Author

yes! Just added the test and all pass for me.

@standage standage merged commit 4037b13 into master Apr 28, 2020
@standage standage deleted the fullsequences branch April 28, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants