-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add STRait Razor output as input #17
Conversation
Ok, @standage , this PR is ready for review pending any suggestions you have. I added the flag By default, STRait Razor output goes to STDOUT and therefore the user has to provide a filename and folder name. In the --help description, I provide guidance on how the folder and filenames should be constructed. The folder name is stripped of any path and outputted in the Analysis ID column; sample IDs are stripped of the '_STRaitRazor.txt' suffix and outputted in the Sample ID column. Is this relying too much on the user? I'm open to have to work around this if you have any suggestions. I included a test in the test_suite.py and a test folder (STRait_Razor_test_output/) of STRait Razor output in the tests/data/ folder. |
I made a minor change so that the results are always sorted. This makes sure the tests pass, which previously were failing on the CI and my laptop. |
Since you said this is ready for review, I assume I can resolve this PR's draft status and remove the WIP from the title. (WIP in the title is GitLab's way to mark a draft PR. It looks like you found the drop-down option in GitHub, in which case the WIP in the title isn't strictly necessary.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR will address adding in the option to input STRait Razor output into the
format
command.STRait Razor outputs individual files for each sample, therefore the code needs to be able to concatenate the sample files and then output the correct format for use in the
annotate
command.