-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SNP workflow #53
Conversation
nofilters: False ##True/False; skip all filtering steps but still creates EFM/STRmix output files | ||
strand: uas ##uas/forward; strand orientation to report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realized I had never added the argument to specify strand orientation.
This is a big one @standage but it's ready for your review. I'm not 10000% confident there aren't some bugs in here since it's so much. But I've tried testing it a bunch and satisfied enough that we can merge it and fix any minor bugs we encounter later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say I'm ready to take over stewardship of this code, but I don't have any big concerns and I understood a fair bit of it! I'll be happy to merge after a couple minor issues are addressed.
lusSTR is able to process SNPs derived from the ForenSeq Signature Prep assay and the ForenSeq Kintelligence assay. SNPs from the ForenSeq Signature Prep assay could be analyzed using either the Verogen UAS or STRait Razor. SNPs from the ForenSeq Kintelligence assay must first be analyzed using the UAS. | ||
|
||
___ | ||
### Creating the STR config file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/paste error: should be "Creating the SNP config file"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol good catch
lusSTR/cli/snps.py
Outdated
# ------------------------------------------------------------------------------------------------- | ||
# Copyright (c) 2020, DHS. | ||
# | ||
# This file is part of lusSTR (http://github.com/bioforensics/lusSTR) and is licensed under | ||
# the BSD license: see LICENSE.txt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it intentional to paste this below the placeholder above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha! I've been scrolled down on this script I've never even realized this was there
import json | ||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want a header in this file for sake of consistency. DHS copyright claim for this particulay code begins 2023, so that would be the appropriate as the year.
lusSTR/wrappers/snps_format.py
Outdated
# ------------------------------------------------------------------------------------------------- | ||
# Copyright (c) 2020, DHS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hair-splitting, but...yeah, 2023 here. 🧐
This PR will convert the old SNP workflow into a snakemake workflow and will likely add some new features along the way!