Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SNP workflow #53

Merged
merged 27 commits into from
Jul 21, 2023
Merged

Create SNP workflow #53

merged 27 commits into from
Jul 21, 2023

Conversation

rnmitchell
Copy link
Contributor

This PR will convert the old SNP workflow into a snakemake workflow and will likely add some new features along the way!

@rnmitchell rnmitchell marked this pull request as draft May 11, 2023 17:02
nofilters: False ##True/False; skip all filtering steps but still creates EFM/STRmix output files
strand: uas ##uas/forward; strand orientation to report
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized I had never added the argument to specify strand orientation.

@rnmitchell rnmitchell marked this pull request as ready for review July 20, 2023 17:59
@rnmitchell
Copy link
Contributor Author

rnmitchell commented Jul 20, 2023

This is a big one @standage but it's ready for your review.

I'm not 10000% confident there aren't some bugs in here since it's so much. But I've tried testing it a bunch and satisfied enough that we can merge it and fix any minor bugs we encounter later.

Copy link
Member

@standage standage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I'm ready to take over stewardship of this code, but I don't have any big concerns and I understood a fair bit of it! I'll be happy to merge after a couple minor issues are addressed.

lusSTR is able to process SNPs derived from the ForenSeq Signature Prep assay and the ForenSeq Kintelligence assay. SNPs from the ForenSeq Signature Prep assay could be analyzed using either the Verogen UAS or STRait Razor. SNPs from the ForenSeq Kintelligence assay must first be analyzed using the UAS.

___
### Creating the STR config file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste error: should be "Creating the SNP config file"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol good catch

Comment on lines 27 to 31
# -------------------------------------------------------------------------------------------------
# Copyright (c) 2020, DHS.
#
# This file is part of lusSTR (http://github.com/bioforensics/lusSTR) and is licensed under
# the BSD license: see LICENSE.txt.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional to paste this below the placeholder above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I've been scrolled down on this script I've never even realized this was there

Comment on lines +1 to +2
import json
import os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want a header in this file for sake of consistency. DHS copyright claim for this particulay code begins 2023, so that would be the appropriate as the year.

Comment on lines 1 to 2
# -------------------------------------------------------------------------------------------------
# Copyright (c) 2020, DHS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hair-splitting, but...yeah, 2023 here. 🧐

@standage standage merged commit d0cd93d into master Jul 21, 2023
@standage standage deleted the snakemake-snps branch July 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants