[ENH] Guardian - infer language and add to corpus #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
lagdetect-guardian
branch
from
35eef3a
to
c177895
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
==========================================
+ Coverage 77.53% 77.73% +0.19%
==========================================
Files 86 86
Lines 12261 12300 +39
Branches 1608 1614 +6
==========================================
+ Hits 9507 9561 +54
+ Misses 2455 2441 -14
+ Partials 299 298 -1 |
PrimozGodec
force-pushed
the
lagdetect-guardian
branch
from
c177895
to
037148b
Compare
|
/rebase |
biolab-helper
force-pushed
the
lagdetect-guardian
branch
from
037148b
to
904e1b8
Compare
|
The change breaks the
|
PrimozGodec
force-pushed
the
lagdetect-guardian
branch
from
904e1b8
to
1de1617
Compare
|
I forgot about setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from #874
Description of changes
Infer language from articles and add it to the corpus
In the current implementation, Corpus variables are created when GuardianAPI is initialized, so they are shared between multiple corpora. The problem appears when different values are added to DiscreteVariable by different calls, so values accumulate. This PR changes that variables are defined in each call separately.
Includes