Merge pull request #2050 from jerneju/valueerror-owfile

[FIX] File: Disallow changing string columns to datetime

Orange/widgets/data/tests/test_owfile.py

@@ -130,7 +130,8 @@ def test_file_not_found(self):
 
     def test_check_column_noname(self):
         """
-        GH-2018
+        Column name cannot be changed to an empty string or a string with whitespaces.
+        GH-2039
         """
         self.open_dataset("iris")
         idx = self.widget.domain_editor.model().createIndex(1, 0)

Orange/widgets/utils/domaineditor.py

@@ -140,9 +140,15 @@ def setEditorData(self, combo, index):
         combo.clear()
         no_numeric = not self.view.model().variables[
             index.row()][Column.not_valid]
-        ind = self.items.index(index.data())
-        combo.addItems(self.items[:1] + self.items[1 + no_numeric:])
-        combo.setCurrentIndex(ind - (no_numeric and ind > 1))
+        if no_numeric:
+            # Do not allow selection of numeric and datetime
+            items = [i for i in self.items if i not in ("numeric", "datetime")]
+        else:
+            items = self.items
+
+        ind = items.index(index.data())
+        combo.addItems(items)
+        combo.setCurrentIndex(ind)
 
 
 class PlaceDelegate(ComboDelegate):