Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictions: IndexError when clicking outside the table #5074

Closed
3 tasks
ajdapretnar opened this issue Nov 6, 2020 · 5 comments · Fixed by #5222
Closed
3 tasks

Predictions: IndexError when clicking outside the table #5074

ajdapretnar opened this issue Nov 6, 2020 · 5 comments · Fixed by #5222
Assignees
Labels
bug A bug confirmed by the core team

Comments

@ajdapretnar
Copy link
Contributor

  • What's wrong?

Predictions crashes when clicking outside the table fields.

-------------------------- AttributeError Exception ---------------------------
Traceback (most recent call last):
  File "/Users/ajda/orange/orange3/Orange/widgets/evaluate/owpredictions.py", line 1130, in select
    self.store.select(selection, flags)
  File "/Users/ajda/orange/orange3/Orange/widgets/evaluate/owpredictions.py", line 1057, in select
    rows = {selection.model().mapToSource(selection).row()}
AttributeError: 'NoneType' object has no attribute 'mapToSource'
-------------------------------------------------------------------------------
  • How can we reproduce the problem?

Create a prediction workflow with a small test data set. Click outside the table.

  • What's your environment?
  • Operating system: OSX
  • Orange version: 3.28.dev
  • How you installed Orange:
@ajdapretnar ajdapretnar added the bug report Bug is reported by user, not yet confirmed by the core team label Nov 6, 2020
@janezd janezd added bug A bug confirmed by the core team good first issue and removed bug report Bug is reported by user, not yet confirmed by the core team labels Nov 13, 2020
@erelin6613
Copy link

Hey, I would like to take a look at this one, may I? Thanks in advance!

@ajdapretnar
Copy link
Contributor Author

@erelin6613 Hello! You are welcome to take this over! ⭐

@irgolic
Copy link
Member

irgolic commented Nov 17, 2020

@erelin6613 Hey, nice to meet you, thanks for the initiative. If you've any questions, feel free to ask on Discord :)

@erelin6613
Copy link

erelin6613 commented Nov 24, 2020

@irgolic @ajdapretnar
I have been trying to dig deep into the warning the terminal was displaying:
QCssParser::parseColorValue: Specified color without alpha value but alpha given: 'rgb 0, 0, 0, 100', I am not sure if it might cause issue or not though.
For now I just added functionality to 'just not break' but was not able to discover some deeper problem if there is any. If you have any idea why SharedSelectionStore.selection.model() could return None, I appreciate you for suggestion. Otherwise a fix for stability is available on my forked repo.

@irgolic
Copy link
Member

irgolic commented Nov 24, 2020

@erelin6613 Create a new branch with your fix on your forked repo, then create a pull request https://github.com/biolab/orange3/compare, and we can see what's up.

You should be able to find some help here: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/working-with-forks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug confirmed by the core team
Projects
None yet
4 participants