Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Predictions: Fix crash when clicking on empty left area #5222

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Jan 29, 2021

Issue

Fixes #5074.

Continues from #5095, where the bug was hunted down by @erelin6613 (thanks!).

Description of changes

Check whether the source model exists before using it.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #5222 (04c271e) into master (516d3d9) will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@           Coverage Diff           @@
##           master    #5222   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files         300      300           
  Lines       60965    60968    +3     
=======================================
+ Hits        51940    51944    +4     
+ Misses       9025     9024    -1     

@janezd janezd force-pushed the fix-predictions-empty-click branch from a447bc8 to 04c271e Compare January 29, 2021 14:02
@ajdapretnar ajdapretnar merged commit b6a16b1 into biolab:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predictions: IndexError when clicking outside the table
2 participants