[ENH] PCA: Add lines and labels showing the explained variance #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.72%@@ master #1383 diff @@
==========================================
Files 75 75
Lines 7419 7419
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6508 6508
Misses 911 911
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket 133 from the to-do list wants "PCA widget: vertical bar should travel in grid (dimensions are integers). Also, mark the intersection of the bar with a dot, and show the projection like of the two dots to the y axis."
Rounding was already implemented (with errors). I added the lines, but also numeric labels, which make the lines redundant. @BlazZupan, do I keep the lines (in this case, you can merge the PR) or do the number suffice?