[FIX] Rand Forest Class: Min sample replaces max leaf nodes #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.64%@@ master #1403 diff @@
==========================================
Files 75 75
Lines 7473 7473
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6550 6550
Misses 923 923
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random forest for classification had a parameter that in the GUI said "Do not split subsets smaller than", but was actually setting another parameter,
max_leaf_nodes. To keep it faithful to the GUI description, themax_leaf_nodeswas replaced withmin_samples_split, so that now the GUI description matches what the learner actually does.Minimum to another pruning parameter,
max_depth, was changed to 1 (scikit-learn counts this as root plus one more level).Some minor cleaning of code was also done to line length to 80 and thus get rid of PyCharm warnings.