[ENH] Enable Ward clustering in Hierarchical clustering widget #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ales-erjavec
commented
Aug 23, 2016
ales-erjavec
commented
- Enable ward clustering in Hierarchical clustering widget
- Implement a workaround for scipy's input checking in scipy.cluster.hierarchy.linkage in scipy 0.16 and 0.17 (scipy issue 5220)
- Adjust limits for clustering in 'Distance map' and 'Heatmap' widgets.
Also add a workaround for erroneous input checking in scipy 0.16 and 0.17 which prevented ward clustering on a precomputed distance matrix.
Current coverage is 88.43% (diff: 56.25%)@@ master #1515 diff @@
==========================================
Files 77 77
Lines 7624 7635 +11
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6729 6752 +23
+ Misses 895 883 -12
Partials 0 0
|
Ensure the return value order is the same when k is equal or larger then the number of leaves.
|
Looks good. @ales-erjavec, should we include a unit test for the currently untested special handling of Ward linkage in scipy prior to 0.18? If yes, then we need to modify travis so that it will test also with older versions of scipy (current requirement is scipy>=0.11.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.