Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Context settings #1577

Merged
merged 4 commits into from
Sep 20, 2016
Merged

[FIX] Context settings #1577

merged 4 commits into from
Sep 20, 2016

Conversation

thocevar
Copy link
Contributor

Problem: Open a widget several times (e.g. Box plot) and change the selected attribute each time. It works only the first and second time. After that (third, fourth time) it will remember the second setting.

Fix:

  • when matching a context, consider lists as valid items
  • don't move up the matched global context if we'll add a new one anyway

@codecov-io
Copy link

codecov-io commented Sep 19, 2016

Current coverage is 88.69% (diff: 100%)

Merging #1577 into master will not change coverage

@@             master      #1577   diff @@
==========================================
  Files            78         78          
  Lines          8108       8108          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7191       7191          
  Misses          917        917          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 7ef8aaa...6cc9921

@astaric astaric merged commit 359f0b3 into biolab:master Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants