[FIX] Scatterplot: Reintroduce sliders for size and opacity #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.66% (diff: 100%)@@ master #1622 diff @@
==========================================
Files 78 78
Lines 8124 8124
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7203 7203
Misses 921 921
Partials 0 0
|
ajdapretnar
requested changes
Oct 3, 2016
There was a problem hiding this comment.
Remove #1619 PR as well, since opacity is now fixed for Selected Data input.
|
You think so? I guess that opacity serves (mostly) aesthetics, while when showing a subset you'd prefer the subset being as visible as possible. I'd keep #1619. |
|
Well, it leads to confusion since the slider is still on and it changes nothing. Then perhaps block the slider on Selected Data input? But I think what @BlazZupan had in mind was changing the slider exactly when the subset is highlighted. Waiting for his input. |
|
Required changes can be addressed in a subsequent pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1621.
@ajdapretnar also complained about the missing sliders, but I told her that it was intentional. We want to simplify the GUI's by selecting optimal colors/sizes/shapes... ourselves instead of having dozens of options.
I remember discussing this, but I'm no longer sure that we reached a conclusion and that the change was indeed intentional: the commit in which this was removed, 71ccfcd, is named "Lint" and doesn't make any other non-lint-related changes.