[FIX] owfile: Hide apply button after resetting editor_model #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.87% (diff: 100%)@@ master #1711 diff @@
==========================================
Files 82 82
Lines 8819 8819
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7838 7838
Misses 981 981
Partials 0 0
|
lanzagar
changed the title
|
Congratulations: you will have to rebase this one-line PR before it can be merged. :) |
janezd
approved these changes
Nov 4, 2016
kernc
suggested changes
Nov 10, 2016
| @@ -263,6 +263,7 @@ def load_data(self): | |||
| # file readers | |||
| # pylint: disable=broad-except | |||
| self.editor_model.set_domain(None) | |||
| self.apply_button.hide() | |||
There was a problem hiding this comment.
Can we please agree disabling is better UX than hiding?
self.apply_button.setEnabled(False)
lanzagar
force-pushed
the
file-apply-de
branch
from
70355e0
to
08338d7
Compare
|
Rebased and switched to disabling/enabling the button instead of hiding/showing. |
Also switch to enabled/disabled button instead of shown/hidden.
lanzagar
force-pushed
the
file-apply-de
branch
from
08338d7
to
8993e54
Compare
kernc
approved these changes
Nov 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
After changes to domain editor the Apply button appears. It was not hidden again when different data was selected.
Description of changes
Hide apply button when load_data is called and editor_model reset.
Includes