Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Confusion matrix: Map annotated data through row_indices, add probabi… #1720

Merged
merged 1 commit into from
Nov 18, 2016

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Nov 4, 2016

…lities to mapped data

Issue

Confusion matrix does not work correctly if the data comes from random sampling, not cross validation. Probabilities are not of the same shape as data, so hstack crashes. Also, annotated data outputs the original data instead of the mapped. For example, (re)sampling iris can produce 510 testing instances, while annotated data contains the original 150.

Description of changes

Widget's self.data now contains mapped data.

Includes
  • Code changes
  • Tests

@codecov-io
Copy link

codecov-io commented Nov 4, 2016

Current coverage is 88.86% (diff: 100%)

Merging #1720 into master will not change coverage

@@             master      #1720   diff @@
==========================================
  Files            82         82          
  Lines          8804       8804          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7824       7824          
  Misses          980        980          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update fd641fc...820e66f

@janezd janezd changed the title Confusion matrix: Map annotated data through row_indices, add probabi… [FIX] Confusion matrix: Map annotated data through row_indices, add probabi… Nov 5, 2016
@ajdapretnar ajdapretnar merged commit 92bba3f into biolab:master Nov 18, 2016
@astaric astaric modified the milestone: 3.3.9 Nov 28, 2016
@janezd janezd deleted the fix-confusion-indices branch April 5, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants