Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] FeatureConstructor: Fix crash when new variable is created without data #1733

Merged
merged 1 commit into from
Nov 10, 2016

Conversation

astaric
Copy link
Member

@astaric astaric commented Nov 7, 2016

Issue

Add a new FeatureConstructor widget, select New > ContinousVariable (without connecting data first).

Widget crashes.

(Solves multiple error reports)

Description of changes

Add a None check

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Nov 7, 2016

Current coverage is 88.87% (diff: 100%)

Merging #1733 into master will not change coverage

@@             master      #1733   diff @@
==========================================
  Files            82         82          
  Lines          8819       8819          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7838       7838          
  Misses          981        981          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 5b60248...7c16d08

@kernc kernc merged commit f215a8b into biolab:master Nov 10, 2016
@astaric astaric modified the milestone: 3.3.9 Nov 28, 2016
@astaric astaric deleted the fix-feature-constructor branch September 8, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants