-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Map widget #1735
[ENH] Map widget #1735
Conversation
01a0052
to
d8c8146
Compare
Can you skip the owmap tests when only PyQt4 is available? As we will not drop support for PyQt4 for some time, it would be nice if the tests still passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Selections on an empty widget result in a crash.
- Zoom to rectangle selection does not work for me.
- Tooltip has duplicates if e.g. shape and color use the same var.
- All other widget windows get closed with Esc on my system except for this one (anything different/non-standard here?)
- When target is selected an error is shown if no learner. If learner is connected and target selected, removing the learner does not show the error (until deselect/select of target var).
Non-urgent wishes (for later PRs; to be discussed):
- This is very similar to Scatter plot so we should strive for similar controls (order of opacity/symbol size; location of jittering; zoom/select controls; etc)
- Also, scatter plot has class density which could be very relevant here as well.
Maybe even more than the included heatmap feature. Even better, we should expand class density to support continuous vars, allow target selection, and include that in both widgets.
Documentation is prepared but waiting for some additional fixes (heatmap for classification and resolution regarding the test data set). I am experiencing the same issues as @lanzagar with additional issue of labeling by name on airports data set. I get AttributeError: 'LeafletMap' object has no attribute '_label_values'. In essence, labeling by string doesn't work for me. |
43c9906
to
4d21b34
Compare
@ajdapretnar Have yet to confirm, but there may not be a classification heatmap so soon.
@lanzagar Any errors in the error console? |
Bumping this to 3.3.10 as it is still under active development and needs documentation etc. |
Current coverage is 89.27% (diff: 50.00%)@@ master #1735 diff @@
==========================================
Files 86 86
Lines 9112 9116 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 8136 8138 +2
- Misses 976 978 +2
Partials 0 0
|
Managed something. |
That's exactly what I had in mind. Thanks! :) Will test it again next week! |
Blocked on #1799. |
5b33dbe
to
4bacffe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous issues seem to be fixed.
Some new ones include:
- Changing lat/long var does not update map!
- Changing from a discrete to continuous target var for overlay has a bug
- Starting zoom is not correct (clicking the center button after that works)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wholeheartedly approve this widget. MASAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping the approval count.
Issue
Add map widget for plotting geospatial data.
Includes