Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] TreeGraph: Compatibility with old schemas #1804

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

astaric
Copy link
Member

@astaric astaric commented Dec 8, 2016

Issue

Classification tree example does not open (#1794)

Description of changes

Declare which widgets are replaced with the new TreeGraph widget.

@astaric
Copy link
Member Author

astaric commented Dec 8, 2016

@ales-erjavec after this fix is applied, the schema shows all widgets, but the signal connecting the Tree widget and the TreeViewer is not created, as the name of the input has changed from Classification Tree to Tree.

Do we have a mechanism that would allow us to declare mapping between old and new signal names? (the way replaces works for widget paths)

@codecov-io
Copy link

codecov-io commented Dec 8, 2016

Current coverage is 89.03% (diff: 100%)

Merging #1804 into master will not change coverage

@@             master      #1804   diff @@
==========================================
  Files            85         85          
  Lines          9019       9019          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           8030       8030          
  Misses          989        989          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 0bb5de1...68d14e7

@ales-erjavec
Copy link
Contributor

Do we have a mechanism that would allow us to declare mapping between old and new signal names? (the way replaces works for widget paths)

No, not yet. Work in progress at wip/channel-ids

@astaric astaric changed the title TreeGraph: Compatibility with old schemas [FIX] TreeGraph: Compatibility with old schemas Dec 8, 2016
@janezd janezd merged commit eedd0ef into biolab:master Dec 9, 2016
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 4, 2017
[FIX] TreeGraph: Compatibility with old schemas
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 4, 2017
[FIX] TreeGraph: Compatibility with old schemas
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 4, 2017
[FIX] TreeGraph: Compatibility with old schemas
@astaric astaric modified the milestone: 3.3.10 Jan 4, 2017
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 6, 2017
[FIX] TreeGraph: Compatibility with old schemas
(cherry picked from commit eedd0ef)
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 10, 2017
[FIX] TreeGraph: Compatibility with old schemas
(cherry picked from commit eedd0ef)
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 11, 2017
[FIX] TreeGraph: Compatibility with old schemas
(cherry picked from commit eedd0ef)
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 13, 2017
[FIX] TreeGraph: Compatibility with old schemas
(cherry picked from commit eedd0ef)
astaric pushed a commit to astaric/orange3 that referenced this pull request Jan 18, 2017
[FIX] TreeGraph: Compatibility with old schemas
(cherry picked from commit eedd0ef)
@astaric astaric deleted the fix-examples branch September 8, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants