[FIX] preprocess: Reset number_of_decimals after scaling #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanzagar
changed the title
Current coverage is 89.28% (diff: 100%)@@ master #1914 diff @@
==========================================
Files 86 86
Lines 9109 9112 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 8133 8136 +3
Misses 976 976
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
After normalization the scaled variable used the same number of decimals as the original.
This meant scaling integers 0..100 to a span of 1 resulted in numbers being shown as 0 or 1 only (instead of 0.4 for example)
Description of changes
After scaling, reset number_of_decimals to 3 (default value of the parameter)
Includes